Repository navigation
Security: Replace raw memcpy with safe std::vector insertion in WriteBytes - #209
Open
Admin135158 wants to merge 1 commit into
Open
Admin135158 wants to merge 1 commit into
Admin135158 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential memory safety issue in
src/transform.cc. The originalWriteBytesfunction used raw C-style pointer arithmetic andmemcpyto append data to astd::vector<uint8_t>. Modern C++ static analyzers (and compilers with-Wunsafe-buffer-usage) flag this pattern because it bypasses the vector's internal bounds checking, risking out-of-bounds writes if the offset or length is miscalculated. This patch replaces the manualresizeandmemcpylogic withstd::vector::insert(). This is a secure-by-design memory safety improvement that eliminates raw pointer arithmetic and leverages the C++ standard library's built-in bounds checking. (Note: I also updated theMakefileto usear crsinstead ofar crffor LLVM compatibility on Termux/Android environments).