Repository navigation
fix(ui): associate and announce test modules validation error in device qualification form - #1675
Merged
Merged
Conversation
…ce qualification form - Add `role="alert"`, `aria-live="polite"`, and a unique `[id]` to the standalone `<mat-error>` in `DeviceQualificationFromComponent` so screen readers announce the error when all test modules are unchecked. - Pass `[errorId]` to `DeviceTestsComponent` and bind `aria-describedby` and `aria-invalid="true"` on both `<section formArrayName="test_modules">` and the underlying `<input type="checkbox">` controls when in an error state. - Add unit tests covering the error live-region attributes, programmatic `aria-describedby` association, and `aria-invalid` state cleanup.
hitnik
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
role="alert",aria-live="polite", and a unique[id]to the standalone<mat-error>inDeviceQualificationFromComponentso screen readers announce the error when all test modules are unchecked.[errorId]toDeviceTestsComponentand bindaria-describedbyandaria-invalid="true"on both<section formArrayName="test_modules">and the underlying<input type="checkbox">controls when in an error state.aria-describedbyassociation, andaria-invalidstate cleanup.