Repository navigation
[TR] The search for risk profiles works inaccurately - #1671
Open
sofyakurilova wants to merge 1 commit into
Open
sofyakurilova wants to merge 1 commit into
sofyakurilova wants to merge 1 commit into
Conversation
hitnik
approved these changes
Oct 23, 2026
hitnik
left a comment
hitnik
left a comment
Collaborator
There was a problem hiding this comment.
Testrun Pull Request Review: PR #1671
Summary of Changes
PR #1671 addresses an issue where searching for risk profiles in the list layout returned inaccurate results.
modules/ui/src/app/components/list-layout/list-layout.component.ts: Removed theriskattribute from the object returned bygetObjectForFilterwhenthis.title() === LayoutType.Profile. Profile filtering now operates exclusively on profilenameand formattedcreateddate (dd MMM yyyy), preventing search queries (such as "High") from inadvertently matching risk evaluation levels across unrelated profiles.modules/ui/src/app/components/list-layout/list-layout.component.spec.ts: Added comprehensive unit test coverage underdescribe('when title is Profile')ensuring filtering operates on profile name and formatted date while ignoring risk and status fields.docs/dev/mockoon.json: Updated mock profiles to align development mock data with test scenarios.
Assessment
- Correctness & Functionality: Verified. The filter predicate matches the expected UX where users filter profiles by name and creation date without unexpected matches against profile risk metadata.
- Test Coverage: Verified. New test specs explicitly test the exclusion of risk/status matches when searching by keyword.
- Code Style & Quality: Clean, well-structured, and adheres to Angular signal/component conventions used across the project.
LGTM!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix risk profiles filtering