Repository navigation
Add typed JSON object lookup helpers find_bool_or, find_int64_or, find_uint64_or, find_double_or, and find_str_or to Value. - #255
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1013102282
branch
from
November 9, 2026 10:26
bd584f9 to
af14342
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_1013102282
branch
2 times, most recently
from
November 9, 2026 15:58
332e7ef to
a5326a0
Compare
…d_uint64_or, find_double_or, and find_str_or to Value. Add concrete lookup helper methods on `Value` (`find_bool_or`, `find_int64_or`, `find_uint64_or`, `find_double_or`, and `find_str_or`) directly in Rust, following the same type naming as the `as_*` accessors (`as_bool`, `as_double`, `as_int64`, `as_uint64`, and `as_str`). They return the provided default when the receiver is not an object, the key is missing or null, or the entry cannot be represented as the target type. PiperOrigin-RevId: 1017353788
copybara-service
Bot
force-pushed
the
test_1013102282
branch
from
November 9, 2026 16:05
a5326a0 to
a79de98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typed JSON object lookup helpers find_bool_or, find_int64_or, find_uint64_or, find_double_or, and find_str_or to Value.
Add concrete lookup helper methods on
Value(find_bool_or,find_int64_or,find_uint64_or,find_double_or, andfind_str_or) directly in Rust, following the same type naming as theas_*accessors (as_bool,as_double,as_int64,as_uint64, andas_str). They return the provided default when the receiver is not an object, the key is missing or null, or the entry cannot be represented as the target type.