Repository navigation
Implement streaming zip reader and tests - #118
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_977770313
branch
12 times, most recently
from
September 16, 2026 11:05
c9d5de5 to
4b9056a
Compare
copybara-service
Bot
force-pushed
the
test_977770313
branch
from
September 20, 2026 14:52
4b9056a to
93fc886
Compare
copybara-service
Bot
force-pushed
the
test_977770313
branch
5 times, most recently
from
October 21, 2026 15:18
3519960 to
ff49b07
Compare
copybara-service
Bot
force-pushed
the
test_977770313
branch
11 times, most recently
from
November 1, 2026 19:29
b5b7bee to
0c23c68
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_977770313
branch
11 times, most recently
from
November 9, 2026 04:29
7377643 to
1531d1d
Compare
Adds `BufferedZipStreamReader`, `FsZipStreamReader` and the `ZipStreamReader` facade, which read a zip archive sequentially from a buffer or a file without seeking, plus a chunked `ReadBytes(max_bytes)` on the entry types. An archive or stream reader refuses to open a second entry while one is still alive (kFailedPrecondition), and a stream reader becomes unusable after a failed `ReadNextFile*`. Reader and archive APIs now return canonical error codes: OS errors such as NotFound are propagated; paths must be non-empty, NUL-free and valid UTF-8; moved-from archives report kFailedPrecondition; and `GetFileByIndex*` reports kInvalidArgument / kFailedPrecondition / kUnimplemented instead of kOutOfRange for corrupt, encrypted or unsupported entries. Also adds `IsNone()` on the archive types and `data()`, `size()`, `empty()` and an `absl::string_view` conversion on `RustVecU8Wrapper`. Includes unit tests. PiperOrigin-RevId: 1017012214
copybara-service
Bot
force-pushed
the
test_977770313
branch
from
November 9, 2026 04:37
1531d1d to
6e886f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement streaming zip reader and tests
Adds
BufferedZipStreamReader,FsZipStreamReaderand theZipStreamReaderfacade, which read a zip archive sequentially from a buffer or a file without
seeking, plus a chunked
ReadBytes(max_bytes)on the entry types. An archiveor stream reader refuses to open a second entry while one is still alive
(kFailedPrecondition), and a stream reader becomes unusable after a failed
ReadNextFile*.Reader and archive APIs now return canonical error codes: OS errors such as
NotFound are propagated; paths must be non-empty, NUL-free and valid UTF-8;
moved-from archives report kFailedPrecondition; and
GetFileByIndex*reportskInvalidArgument / kFailedPrecondition / kUnimplemented instead of kOutOfRange
for corrupt, encrypted or unsupported entries. Also adds
IsNone()on thearchive types and
data(),size(),empty()and anabsl::string_viewconversion on
RustVecU8Wrapper. Includes unit tests.