Add remove_duplicates ignore_comments and merge_comments logic - #132
Merged
KatrinaHoffert merged 3 commits intoAug 18, 2026
Conversation
Added `DuplicateResolution` enum to handle advanced deduplication modes. The new mores are `ignore_comments` to keep only the first comment for deduplicated items and `merge_comments` to merge comments from all identical items when deduplicated (identical comment lines are also deduplicated when merging).
wachsler-google
previously requested changes
Aug 8, 2026
wachsler-google
left a comment
wachsler-google
left a comment
Collaborator
There was a problem hiding this comment.
Sorry I don't have much experience with github reviews, so I posted a couple comments separate from this review before I figured out how this works. Anyway, this all looks pretty good, aside from the few things I've commented on.
- Use slices.Clone before deduplication loop when merging comments - Rename remove_duplicates=ignore_comments to keep_first_comment everywhere - Remove duplicate new line - Add tests for remove_duplicates option parsing and resolution
Contributor
Author
Feedback should be all addressed now. Thank you for the review! |
KatrinaHoffert
approved these changes
Aug 14, 2026
- In keep_first_comment mode, retain the first non-empty comment across duplicates if the initial occurrence has no comment - In merge_comments mode, deduplicate merged comments at the comment-block level rather than line-by-line to preserve multi-line comments and paragraph breaks - Add doc comments to DuplicateResolution in keepsorted/options.go - Update golden tests and README documentation
KatrinaHoffert
dismissed
wachsler-google’s stale review
August 18, 2026 01:32
All comments were resolved. Dismissing rather than re-requesting review to avoid us doing extra reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
DuplicateResolutionenum to handle advanced deduplication modes. The new mores areignore_commentsto keep only the first comment for deduplicated items andmerge_commentsto merge comments from all identical items when deduplicated (identical comment lines are also deduplicated when merging).