Repository navigation
posture-aware Activity orientation and landscape PreviewDisplay framing #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Kimblebee
wants to merge
8
commits into
main
Choose a base branch
from
kim/adaptive/preview-display-framing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
37ff240
feat(ui): support adaptive landscape framing and LTR isolation in Pre…
Kimblebee fe40e9d
Improve PreviewDisplay accessibility semantics, custom actions, and k…
Kimblebee 5c284c9
Merge remote-tracking branch 'origin/main' into kim/adaptive/preview-…
Kimblebee 19312ba
Merge branch 'main' into kim/adaptive/preview-display-framing
Kimblebee 766dbe0
feat(app, preview): enable landscape viewfinder framing and multi-win…
Kimblebee 5605cff
Merge remote-tracking branch 'origin/main' into kim/adaptive/preview-…
Kimblebee 723f876
Merge remote-tracking branch 'origin/main' into kim/adaptive/preview-…
Kimblebee 3931a32
Reuse camera viewfinder string, add JUnit4 runner, and strip redundan…
Kimblebee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
app/src/test/java/com/google/jetpackcamera/MainActivityOrientationTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Copyright (C) 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.jetpackcamera | ||
|
|
||
| import android.content.pm.ActivityInfo | ||
| import com.google.common.truth.Truth.assertThat | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import org.junit.runners.JUnit4 | ||
|
|
||
| /** | ||
| * Unit tests for [resolveRequestedOrientation]. | ||
| */ | ||
| @RunWith(JUnit4::class) | ||
| class MainActivityOrientationTest { | ||
|
|
||
| @Test | ||
| fun resolveRequestedOrientation_fullScreenCompactPhone_locksToNoSensor() { | ||
| assertThat( | ||
| resolveRequestedOrientation( | ||
| isInMultiWindowMode = false, | ||
| smallestScreenWidthDp = 411 | ||
| ) | ||
| ).isEqualTo(ActivityInfo.SCREEN_ORIENTATION_NOSENSOR) | ||
|
|
||
| assertThat( | ||
| resolveRequestedOrientation( | ||
| isInMultiWindowMode = false, | ||
| smallestScreenWidthDp = 599 | ||
| ) | ||
| ).isEqualTo(ActivityInfo.SCREEN_ORIENTATION_NOSENSOR) | ||
| } | ||
|
|
||
| @Test | ||
| fun resolveRequestedOrientation_multiWindowCompact_allowsUnspecifiedOrientation() { | ||
| assertThat( | ||
| resolveRequestedOrientation( | ||
| isInMultiWindowMode = true, | ||
| smallestScreenWidthDp = 411 | ||
| ) | ||
| ).isEqualTo(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED) | ||
| } | ||
|
|
||
| @Test | ||
| fun resolveRequestedOrientation_largeScreenOrFoldable_allowsUnspecifiedOrientation() { | ||
| assertThat( | ||
| resolveRequestedOrientation( | ||
| isInMultiWindowMode = false, | ||
| smallestScreenWidthDp = 600 | ||
| ) | ||
| ).isEqualTo(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED) | ||
|
|
||
| assertThat( | ||
| resolveRequestedOrientation( | ||
| isInMultiWindowMode = true, | ||
| smallestScreenWidthDp = 673 | ||
| ) | ||
| ).isEqualTo(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling
isInMultiWindowModedirectly as a default parameter value will cause aNoSuchMethodErrorcrash on devices running API levels below 24 (Android 7.0), as this property was introduced in API 24. Since the app's minimum SDK version is likely lower (e.g., API 21), this call must be guarded with an API level check.