Optimize Gemma 4 MoE router input buffering and scaling:#965
Open
copybara-service[bot] wants to merge 1 commit into
Open
Optimize Gemma 4 MoE router input buffering and scaling:#965copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_954067115
branch
from
July 26, 2026 16:54
3c91c6a to
29a2b10
Compare
- Changed `router_in` storage type from `BF16` to `float` in `Activations` to avoid `BF16`->`float`->`BF16` round-tripping. - Copies pre-FFW activations directly to the `float` `router_in` without type conversion. - Performs fused inline scaling using Highway SIMD (`Decompress1AndCompressInplace`) avoiding per-token type roundtrips and temporary vector allocations. PiperOrigin-RevId: 954067115
copybara-service
Bot
force-pushed
the
test_954067115
branch
from
July 27, 2026 07:00
29a2b10 to
3b167ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize Gemma 4 MoE router input buffering and scaling:
router_instorage type fromBF16tofloatinActivationsto avoidBF16->float->BF16round-tripping.floatrouter_inwithout type conversion.Decompress1AndCompressInplace) avoiding per-token type roundtrips and temporary vector allocations.