Skip to content

tests: Ensure malformed symbol remains invalid - #505

Merged
jriv01 merged 1 commit into
google:mainfrom
jriv01:ensure-invalid-symbol
Aug 27, 2026
Merged

tests: Ensure malformed symbol remains invalid#505
jriv01 merged 1 commit into
google:mainfrom
jriv01:ensure-invalid-symbol

Conversation

@jriv01

@jriv01 jriv01 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Newer versions of the Swift demangler return true on isSwiftSymbol("_TMXfZD") due to _T being a real legacy prefix for Swift mangling. This change updates the symbol name to ensure that it is invalid, and is not accidentally parsed by the Swift demangler.

@jriv01
jriv01 requested a review from haberman August 27, 2026 19:15
@jriv01

jriv01 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Failed checks for Windows CI seem to be due to an issue with using windows-latest as the runner, instead of an issue with this pull request.

Opened #506 to follow up

@jriv01
jriv01 merged commit 24fbe66 into google:main Aug 27, 2026
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants