Fix typos in _einsum_utils docstring/comment - #748
Closed
PratikDhanave wants to merge 1 commit into
Closed
Conversation
- 'reqrites a einsum' -> 'rewrites an einsum' - 'This assume there's no elipsis' -> 'This assumes there's no ellipsis'
Author
|
Superseded by #763, which bundles this typo fix with the other pure-typo fixes into a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small typo/grammar fixes in
gemma/peft/_einsum_utils.py(get_lora_einsum_str_and_shapes):reqrites a einsum->rewrites an einsumThis assume there's no elipsis->This assumes there's no ellipsisComment/docstring only; no behavior change.