Skip to content

POC: Upgrade Hugo to 0.164.0 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
czechian wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

POC: Upgrade Hugo to 0.164.0 #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ canonifyURLs = true
# Disable, it makes problems with Netlify (missing internal redirect .../path -> .../path/)
# relativeURLs = true

disableKinds = ["taxonomy", "taxonomyTerm"]
disableKinds = ["taxonomy", "term"]

# Highlighting config
pygmentsCodeFences = true
Expand Down Expand Up @@ -54,7 +54,7 @@ section = [ "HTML" ]
[languages]
[languages.en]
title = "GoodData Docs Theme"
languageName = "English"
label = "English"
# Weight used for sorting.
weight = 1

Expand Down Expand Up @@ -161,12 +161,20 @@ notAlternative = true
[security]
[security.funcs]
getenv = ["^HUGO_", "^hugo_"]
# Hugo >= 0.161 runs PostCSS under the Node.js permission model with reads
# confined to the project dir. Browserslist probes every ancestor directory
# (package.json, browserslist-stats.json), so reads must stay unrestricted;
# write/child-process/addon restrictions remain at their defaults.
[security.node.permissions]
allowRead = ["*"]

[module]
proxy = "direct"
[module.hugoVersion]
extended = true
min = "0.81.0"
# Templates use hugo.IsServer / .Site.Config.Services (Hugo >= 0.120);
# tested with Hugo 0.164.0.
min = "0.120.0"
[[module.imports]]
path = "github.com/google/docsy"
disable = false
Expand Down
6 changes: 3 additions & 3 deletions docs/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ weight: 1
cascade:
- type: "docs"
toc_root: true
_target:
target:
path: "/*"
- type: "docs"
toc_root: true
_target:
target:
path: "/*/**"
- type: "docs"
toc_root: true
_target:
target:
Comment on lines +8 to +16

@coderabbitai coderabbitai Bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick win

YAML list marker misplacement during _target → target migration. The front-matter cascade migration from Hugo's deprecated _target key to target may have orphaned the YAML - list marker onto type: instead of target:, producing invalid YAML. Both files need the - on the target: line.

  • docs/_index.md#L8-L16: Move - from type: (lines 10, 14) to target: (lines 8, 12) and adjust indentation so path: nests under target: and type:/toc_root: are siblings within each list item.
  • docs/pages/docs-homepage.md#L12-L12: Verify the full cascade YAML structure — if it uses list-style cascade entries, ensure - is on target:, not type:.
📍 Affects 2 files
  • docs/_index.md#L8-L16 (this comment)
  • docs/pages/docs-homepage.md#L12-L12
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/_index.md` around lines 8 - 16, The cascade YAML in docs/_index.md lines
8-16 has misplaced list markers: move each “-” from type: to the corresponding
target: entry and indent path: beneath target:, with type: and toc_root: as
siblings. Verify docs/pages/docs-homepage.md line 12 similarly and make the same
structural correction if it uses list-style cascade entries.

path: "/_index.md"

---
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/docs-homepage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ layout: "list"
cascade:
- type: "docs"
toc_root: true
_target:
target:
path: "/*/**"
---

Expand Down
2 changes: 1 addition & 1 deletion layouts/_default/content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ <h1>{{ .Title }}</h1>
{{ if and .Params.sectionIndex .Parent }}
{{ partial "section-index.html" .Parent }}
{{ end }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.GoogleAnalytics)) }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.Config.Services.GoogleAnalytics.ID)) }}
{{ partial "feedback.html" .Site.Params.ui.feedback }}
<br />
{{ end }}
Expand Down
2 changes: 1 addition & 1 deletion layouts/api-reference/content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h1>{{ .Title }}</h1>
{{ if and .Params.sectionIndex .Parent }}
{{ partial "section-index.html" .Parent }}
{{ end }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.GoogleAnalytics)) }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.Config.Services.GoogleAnalytics.ID)) }}
{{ partial "feedback.html" .Site.Params.ui.feedback }}
<br />
{{ end }}
Expand Down
4 changes: 2 additions & 2 deletions layouts/docs/list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ <h1>{{ .Title }}</h1>
{{ if ne .Params.sectionIndex false }}
{{ partial "section-index.html" . }}
{{ end }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.GoogleAnalytics)) }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.Config.Services.GoogleAnalytics.ID)) }}
{{ partial "feedback.html" .Site.Params.ui.feedback }}
<br />
{{ end }}

{{ partial "prev-next-pages.html" . }}

{{ if (.Site.DisqusShortname) }}
{{ if (.Site.Config.Services.Disqus.Shortname) }}
<br />
{{ partial "disqus-comment.html" . }}
{{ end }}
Expand Down
4 changes: 2 additions & 2 deletions layouts/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ <h1>{{.Title}}</h1>
{{ if ne .Params.sectionIndex false }}
{{ partial "section-index.html" . }}
{{ end }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.GoogleAnalytics)) }}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.Config.Services.GoogleAnalytics.ID)) }}
{{ partial "feedback.html" .Site.Params.ui.feedback }}
<br/>
{{ end }}

{{ partial "prev-next-pages.html" . }}

{{ if (.Site.DisqusShortname) }}
{{ if (.Site.Config.Services.Disqus.Shortname) }}
<br/>
{{ partial "disqus-comment.html" . }}
{{ end }}
Expand Down
9 changes: 8 additions & 1 deletion layouts/partials/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
{{/* (C) 2026 GoodData Corporation */}}
{{ $footer := getJSON "https://www.gooddata.ai/learn-assets/js/footer-definition-new.json" }}
{{/* A failed fetch fails the build, matching the old getJSON behavior. */}}
{{ $footerURL := "https://www.gooddata.ai/learn-assets/js/footer-definition-new.json" }}
{{ $footer := dict }}
{{ with resources.GetRemote $footerURL }}
{{ $footer = . | transform.Unmarshal }}
{{ else }}
{{ errorf "footer.html: unable to fetch %s" $footerURL }}
{{ end }}
{{ if not .Site.Params.whitelabeled }}

<footer class="gd-footer" aria-label="Page footer">
Expand Down
2 changes: 1 addition & 1 deletion layouts/partials/head-css.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{/* (C) 2026 GoodData Corporation */}}
{{ $scssMain := "scss/main.scss"}}
{{ if .Site.IsServer }}
{{ if hugo.IsServer }}
{{/* Note the missing postCSS. This makes it snappier to develop in Chrome, but makes it look sub-optimal in other browsers. */}}
{{ $css := resources.Get $scssMain | toCSS (dict "enableSourceMap" true) }}
<link href="{{ $css.RelPermalink }}" rel="stylesheet">
Expand Down
2 changes: 1 addition & 1 deletion layouts/partials/section-index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ <h2> (not <h5>) so the document heading order never skips a level; the
{{ $pages = (where $pages "Type" "!=" "search") }}
{{ $pages = (where $pages ".Params.hide_summary" "!=" true) }}
{{ $pages = (where $pages ".Parent" "!=" nil) }}
{{ $pages = (where $pages "Parent.File.UniqueID" "==" $parent.File.UniqueID) }}
{{ $pages = (where $pages "Parent.Path" "==" $parent.Path) }}
{{ if or $parent.Params.no_list (eq (len $pages) 0) }}
{{/* If no_list is true or we don't have subpages we don't show a list of subpages */}}
{{ else if $parent.Params.simple_list }}
Expand Down
28 changes: 28 additions & 0 deletions layouts/swagger/list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{{/* (C) 2026 GoodData Corporation
Shadow of Docsy 0.7.1's swagger/list.html. The upstream file has a parse
error (`.- ` instead of `. -`) that Hugo >= 0.146 rejects during its eager
template parsing, and it reads Site fields removed in newer Hugo. Drop
this override once Docsy is upgraded past 0.7.x. */}}
{{ define "main" }}
<div class="td-content">
<h1>{{ .Title }}</h1>
{{ with .Params.description }}<div class="lead">{{ . | markdownify }}</div>{{ end }}
<header class="article-meta">
{{ partial "taxonomy_terms_article_wrapper.html" . -}}
{{ if (and (not .Params.hide_readingtime) (.Site.Params.ui.readingtime.enable)) -}}
{{ partial "reading-time.html" . -}}
{{ end -}}
</header>
{{ .Content }}
{{ partial "section-index.html" . -}}
{{ if (and (not .Params.hide_feedback) (.Site.Params.ui.feedback.enable) (.Site.Config.Services.GoogleAnalytics.ID)) -}}
{{ partial "feedback.html" .Site.Params.ui.feedback -}}
<br />
{{ end -}}
{{ if (.Site.Config.Services.Disqus.Shortname) -}}
<br />
{{ partial "disqus-comment.html" . -}}
{{ end -}}
{{ partial "page-meta-lastmod.html" . -}}
</div>
{{ end -}}
4 changes: 4 additions & 0 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,9 @@

# Node 20 is required for PostCSS/CSS minification and the audit scripts.
# (.nvmrc also pins this; kept here so it's explicit in CI.)
# HUGO_VERSION pins the Netlify-provided `hugo` binary used by the deploy
# build; keep it in sync with hugo-extended in package.json (used by the
# a11y audit and local npm scripts).
[build.environment]
NODE_VERSION = "20"
HUGO_VERSION = "0.164.0"
Loading