Repository navigation
docs: engine#418 root cause found and characterized; round 48's own strict-mode fix retracted - #445
Merged
Merged
Conversation
…trict-mode fix retracted (round 48) Round 48 reproduced the goja compiler bug behind engine#418 in isolation against the exact real i18next resolve() shape, and corrected two of round 47's conclusions along the way (the nested forEach callbacks run; they don't get skipped). An earlier, over-simplified reduction inside this same round wrongly suggested "use strict" fixes it; directly re-tested against the real function shape (including goja.Compile's own strict parameter and splitting the var statement), none of it holds up, so the js/transpile.go change this round shipped first is reverted in full. No safe engine-level mitigation exists: the only thing that avoids the bug is removing the arguments[] read from third-party minified source, which this fallback cannot do without a real AST. Likely cause traced to goja's compiler.go:614-834/compiler_expr.go:1559-1615 for an upstream report. engine#418 stays open. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiler bug in isolation against the exact real i18next
resolve()shape, and corrects two of round 47's own conclusions: the nested
forEachcallbacks run (they are not skipped), and"use strict"(confirmed active via a runtime probe, both standalone and on the real
page) does NOT fix the real symptom, contradicting an earlier,
over-simplified reduction from inside this same round.
plain
arguments[N]read in third-party, already-minified source thatthis fallback cannot rewrite without a real AST.
js/transpile.goisreverted in full back to its pre-round-48 state.
future upstream
dop251/gojareport or a carefully-scoped AST-basedmitigation.
Docs-only change (
FIDELITY.md); no production code changed net thisround.
Test plan
git diffonjs/is empty (full revert confirmed)go build ./...,go vet ./...,gofmt -l .cleangovulncheck ./...clean🤖 Generated with Claude Code