Skip to content

docs: engine#418 root cause found and characterized; round 48's own strict-mode fix retracted - #445

Merged
tannevaled merged 1 commit into
mainfrom
docs-engine418-round48
Nov 21, 2026
Merged

tannevaled merged 1 commit into
mainfrom
docs-engine418-round48

Conversation

@tannevaled

Copy link
Copy Markdown
Contributor

Summary

  • Round 48's investigation of engine#418 reproduced the underlying goja
    compiler bug in isolation against the exact real i18next resolve()
    shape, and corrects two of round 47's own conclusions: the nested
    forEach callbacks run (they are not skipped), and "use strict"
    (confirmed active via a runtime probe, both standalone and on the real
    page) does NOT fix the real symptom, contradicting an earlier,
    over-simplified reduction from inside this same round.
  • No safe engine-level mitigation was found this round: the trigger is a
    plain arguments[N] read in third-party, already-minified source that
    this fallback cannot rewrite without a real AST. js/transpile.go is
    reverted in full back to its pre-round-48 state.
  • engine#418 stays open, with the mechanism now fully characterized for a
    future upstream dop251/goja report or a carefully-scoped AST-based
    mitigation.

Docs-only change (FIDELITY.md); no production code changed net this
round.

Test plan

  • git diff on js/ is empty (full revert confirmed)
  • go build ./..., go vet ./..., gofmt -l . clean
  • govulncheck ./... clean
  • No new/changed tests needed — documentation only

🤖 Generated with Claude Code

…trict-mode fix retracted (round 48)

Round 48 reproduced the goja compiler bug behind engine#418 in isolation
against the exact real i18next resolve() shape, and corrected two of round
47's conclusions along the way (the nested forEach callbacks run; they
don't get skipped). An earlier, over-simplified reduction inside this
same round wrongly suggested "use strict" fixes it; directly re-tested
against the real function shape (including goja.Compile's own strict
parameter and splitting the var statement), none of it holds up, so the
js/transpile.go change this round shipped first is reverted in full.

No safe engine-level mitigation exists: the only thing that avoids the
bug is removing the arguments[] read from third-party minified source,
which this fallback cannot do without a real AST. Likely cause traced to
goja's compiler.go:614-834/compiler_expr.go:1559-1615 for an upstream
report. engine#418 stays open.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
@tannevaled
tannevaled merged commit 9dea5fc into main Nov 21, 2026
13 checks passed
@tannevaled
tannevaled deleted the docs-engine418-round48 branch November 21, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant