Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,24 @@ permissions:

env:
CGO_ENABLED: "0"
# ⛔ KEEP THIS EQUAL TO go.mod's `go` DIRECTIVE. It is the toolchain the
# artefacts are built with, and the standard library is judged by it: on
# 2026-10-31 this said 1.27.2 while GO-2026-6809 (crypto/x509
# Certificate.Verify) was reachable from cmd/browserproxy, fixed in go1.27.3.
# Raising go.mod alone would leave the lane building the vulnerable one.
GO_VERSION: "1.27.3"
# ⛔ GO_VERSION IS GONE, AND THE COMMENT IT CARRIED IS WHY. It said:
#
# KEEP THIS EQUAL TO go.mod's `go` DIRECTIVE. [...] Raising go.mod alone
# would leave the lane building the vulnerable one.
#
# That was right, and it was a rule with nothing to enforce it. On 2026-11-15
# the directive moved to 1.27.4 for GO-2026-6859 while this still said
# "1.27.3" — the note's own warning, two weeks later. `setup-go` sets
# GOTOOLCHAIN=local, so the lane does not build the older toolchain quietly:
# it REFUSES with `go.mod requires go >= 1.27.4`. Measured the same day on
# five of six go-filesystems repositories, every job red at once.
#
# So each step now reads `go-version-file: go.mod` instead. The equality the
# comment asked for is structural rather than requested, and the next raise
# needs no edit here. ⚠ An expression like `${{ env.GO_VERSION }}` also hid
# this from `gofloor`, which classifies a hard-coded pin as a finding but an
# expression as merely "expression" — a literal one indirection away was
# invisible to the auditor written to find exactly this.

jobs:
test:
Expand All @@ -39,7 +51,7 @@ jobs:

- uses: actions/setup-go@v7
with:
go-version: ${{ env.GO_VERSION }}
go-version-file: go.mod
check-latest: true

- name: Build (CGO_ENABLED=0)
Expand Down Expand Up @@ -68,7 +80,7 @@ jobs:

- uses: actions/setup-go@v7
with:
go-version: ${{ env.GO_VERSION }}
go-version-file: go.mod
check-latest: true

- name: Build for linux/${{ matrix.goarch }}
Expand All @@ -85,7 +97,7 @@ jobs:

- uses: actions/setup-go@v7
with:
go-version: ${{ env.GO_VERSION }}
go-version-file: go.mod
check-latest: true

- uses: actions/setup-node@v7
Expand Down
26 changes: 25 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,30 @@
module github.com/go-webengine/browserproxy

go 1.27.3
// ⛔ THE PATCH, AND THIS REPOSITORY IS ONE OF THE NINE THE FLEET SWEEPS FOR
// EXPOSURE: it is the browser proxy, network in, untrusted HTML parsed. This
// line is the only one of the three Go pins a CONSUMER honours — `go install`
// with GOTOOLCHAIN=local obeys it, while the CI pin merely builds our artefacts
// and the toolchain stamped in a binary describes one executable.
//
// Raised to 1.27.4 on 2026-11-15 for GO-2026-6859 — published 2026-11-11,
// CVE-2026-97054, "HTTP/1 server crash due to MaxBytesReader header race in
// net/http", stdlib, fixed in 1.26.11 and 1.27.4. Read at
// https://vuln.go.dev/ID/GO-2026-6859.json rather than quoted from notes.
//
// ⛔ AND THIS ONE IS A PROXY: it SERVES HTTP as well as fetching it, so an
// advisory about an HTTP/1 server is this program's own class rather than a
// contract detail. (Whether its handlers reach the racing path is a
// REACHABILITY question, which govulncheck answers and this line does not.)
//
// Measured, not assumed: `modfloor --floor 1.27.4` read the directive this
// module PUBLISHED at v0.2.1 as `go 1.27.3`. Eight of the nine network-facing
// modules read BELOW; only go-webengine/engine was already at 1.27.4. This is
// the second-to-last of the eight.
//
// Previous raise, kept because the record is the point: 1.27.2 -> 1.27.3 on
// 2026-10-31 for GO-2026-6809 (crypto/x509 Certificate.Verify), which was
// REACHABLE from cmd/browserproxy — not merely required.
go 1.27.4

require (
github.com/go-webengine/engine v0.18.1
Expand Down
Loading