Repository navigation
Preserve all slice entries when zeroing a weakly decoded map - #216
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combining
WeaklyTypedInputandZeroFieldscurrently keeps only the last map in a slice. For example, decoding[{"a": 1}, {"b": 2}]produces{"b": 2}instead of the documented merged map.Decode each item separately and accumulate its entries in the destination cleared for the whole slice. Nested values still use
ZeroFields, later keys still win, and the decoder configuration stays unchanged. The temporary value retains the target observed by decode hooks.Regressions cover map/array/interface slices, duplicate keys, empty and nil items, nested maps and slices, decoder reuse, partial errors and hook targets. Nine cases fail before the change; all 17 cases pass after it. The full race/shuffle suite, vet, build, configured formatting and golangci-lint 2.6.2 pass on macOS arm64 with Go 1.26.0. Other Go/OS combinations were not run locally.