Repository navigation
ci: send coverage from the Go 1.26.x leg (step skipped since #1535) - #1671
Merged
nodivbyzero merged 2 commits intoOct 14, 2026
Merged
Conversation
The "Send Coverage" step is gated on matrix.go-version == '1.24.x', but 1.24.x left the test matrix in go-playground#1535 (Go 1.26 support), so the step has been skipped on every job since and Coveralls has had no master build after f5c74ce (2026-02-17). Point the condition at 1.27.x, the newest version in the matrix, as earlier Go bumps did. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Coverage is 72.569% — glaziermag:ci/send-coverage-go-1.27 into go-playground:master. No base build found for |
nodivbyzero
reviewed
Oct 14, 2026
Co-authored-by: nodivbyzero <[email protected]>
nodivbyzero
approved these changes
Oct 14, 2026
nodivbyzero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Send Coveragein.github/workflows/workflow.ymlonly runs whenmatrix.go-version == '1.24.x', and #1535 (Go 1.26 support) took 1.24.x out of the matrix. No job has matched since, so the step is skipped on every run and Coveralls has had nomasterbuild after f5c74ce (2026-02-17, 60 commits back). The README badge still shows that build's 74%.This points the condition at
1.27.x, the newest version in the matrix, as earlier Go bumps did (4a1bc2f, 909c504).To check:
masterrun, 38437806547:Send Coverageis skipped in all sixtestjobs.curl -s 'https://coveralls.io/github/go-playground/validator.json?branch=master'returns"created_at":"2026-02-17T17:35:49Z"and"commit_sha":"f5c74ce5...".test (1.27.x, ubuntu-latest)only and the upload succeeds: job log. That build reported 69.6% for the same tree.Coveralls will compare this PR against the February build, so its status may show a drop. The diff touches no Go code.
The literal needs the same bump in the next Go-version PR. An
includeentry carryingcoverage: truewould avoid that, if you prefer it.Make sure that you've checked the boxes below before you submit PR:
Not applicable: workflow-only change.
@go-playground/validator-maintainers
Generated with Claude Code (Claude Opus 5.5), disclosed per the AI Agents section of CONTRIBUTING. The commit carries the
Co-Authored-Bytrailer.