Skip to content

fix(baked_in): reject all-numeric dotted quad addresses in hostname_rfc1123 #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamMagued wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(baked_in): reject all-numeric dotted quad addresses in hostname_rfc1123 #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion baked_in.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2916,7 +2916,32 @@ func isHostnameRFC952(fl FieldLevel) bool {
}

func isHostnameRFC1123(fl FieldLevel) bool {
return hostnameRegexRFC1123().MatchString(fl.Field().String())
val := fl.Field().String()
if !hostnameRegexRFC1123().MatchString(val) {
return false
}
// Per RFC 1123 Section 2.1, host names cannot have the dotted-decimal
// format #.#.#.# unless they represent a valid IP address. If the value
// has four dot-separated numeric parts, verify that it parses as a valid IP.
if looksLikeIPv4(val) {
return net.ParseIP(val) != nil
}
return true
}

// looksLikeIPv4 reports whether s consists of exactly four dot-separated
// numeric components (e.g. "192.168.0.1", "277.168.0.1").
func looksLikeIPv4(s string) bool {
parts := 1
for i := 0; i < len(s); i++ {
c := s[i]
if c == '.' {
parts++
} else if c < '0' || c > '9' {
return false
}
}
return parts == 4
}

func isHostnameLabel(fl FieldLevel) bool {
Expand Down
21 changes: 21 additions & 0 deletions validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11248,6 +11248,20 @@ func TestHostnameRFC1123Validation(t *testing.T) {
{"example.", false},
{"test_example", false},
{"192.168.0.1", true},
{"277.168.0.1", false},
{"999.999.999.999", false},
{"1.2.3.256", false},
{"256.0.0.1", false},
{"0.0.0.0", true},
{"255.255.255.255", true},
{"3com.com", true},
{"1and1.com", true},
{"7-eleven.com", true},
{"1234", true},
{"12345", true},
{"1.2.3", true},
{"1.2.3.4.5", true},
{"192.168.0.a", true},
{"[email protected]", false},
{"2001:cdba:0000:0000:0000:0000:3257:9652", false},
{"2001:cdba:0:0:0:0:3257:9652", false},
Expand Down Expand Up @@ -11308,6 +11322,13 @@ func TestHostnameRFC1123AliasValidation(t *testing.T) {
{"example.", false},
{"test_example", false},
{"192.168.0.1", true},
{"277.168.0.1", false},
{"999.999.999.999", false},
{"1.2.3.256", false},
{"0.0.0.0", true},
{"255.255.255.255", true},
{"1.2.3", true},
{"1234", true},
{"[email protected]", false},
{"2001:cdba:0000:0000:0000:0000:3257:9652", false},
{"2001:cdba:0:0:0:0:3257:9652", false},
Expand Down
Loading