build: update libgit2 to 1.9.4 - #98
Conversation
Migrate ObjectiveGit to the current libgit2 APIs and retain SSH transport support. Signed-off-by: Hiram Chirino <[email protected]>
|
I gave this a try against GitX itself, since CI here builds the framework What I ranChecked this branch out with
To be precise about how far that goes: it is compile plus unit tests. One change needed on the GitX sideGitX has exactly one line that does not compile against That turned out to be a pre-existing GitX bug rather than anything this PR causes. That fix is independent of this PR and safe against the current One review pointIn - git_error_set_str(GIT_EUSER, "No GTCredentialProvider set, but authentication was requested.");
- return GIT_ERROR;
+ return GIT_EAUTH;
The rest reads well to me. Migrating to |
Summary
Update ObjectiveGit from libgit2 0.28.5 to 1.9.4 and migrate the wrapper to current libgit2 APIs. Preserve SSH transport support in the framework build.
Changes