fix(extensions): re-validate catalog URL after redirects (HTTPS parity/security)#3524
Open
jawwad-ali wants to merge 1 commit into
Open
fix(extensions): re-validate catalog URL after redirects (HTTPS parity/security)#3524jawwad-ali wants to merge 1 commit into
jawwad-ali wants to merge 1 commit into
Conversation
ExtensionCatalog._fetch_single_catalog opened the catalog URL and trusted the payload without re-validating response.geturl() after redirects. _open_url follows redirects (stripping auth only on an HTTPS->HTTP downgrade), so an https:// catalog entry that 30x-redirects to http://attacker/... was still fetched and trusted. The payload supplies each extension's download_url + sha256, so a redirected payload can drive install of an arbitrary archive that passes sha256 verification. Add the post-redirect geturl() re-validation via _validate_catalog_url, mirroring integrations/catalog.py, presets, workflows/catalog.py, and bundler adapters. Sibling of the same fix in the presets catalog fetcher. Test: an HTTPS URL whose response.geturl() reports http:// is rejected (ExtensionError). Completed existing fetch-test mocks that predated this behavior to report geturl() like a real urllib response. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ExtensionCatalog._fetch_single_catalogfetched the catalog JSON and trusted it without re-validating the post-redirect URL — the same gap as in the presets catalog fetcher:_open_urlfollows redirects (stripping auth only on an HTTPS→HTTP downgrade), so anhttps://catalogentry.urlthat 30x-redirects tohttp://attacker/catalog.jsonis still fetched and trusted. The payload supplies each extension'sdownload_urlandsha256, so an attacker-controlled redirected payload defeats sha256 verification and can drive installation of an arbitrary archive.Fix
Re-validate
response.geturl()after the redirect via_validate_catalog_url, mirroringintegrations/catalog.py,workflows/catalog.py,bundler/services/adapters.py, and the presets catalog fetcher. This is the extensions sibling of the presets fix.Test
test_fetch_single_catalog_revalidates_redirected_url: an HTTPS URL whoseresponse.geturl()reportshttp://is rejected withExtensionError(fails before: no revalidation). Existing fetch-test mocks were completed to reportgeturl()like a realurllibresponse.🤖 Written with the assistance of Claude Code (AI). Bug self-found; fix/tests verified locally (fail-before / pass-after).