Skip to content

Remove unused updater timeout fixture - #1756

Merged
jeffwidman merged 1 commit into
mainfrom
cleanup/remove-updater-timeout-fixture
Aug 12, 2026
Merged

jeffwidman merged 1 commit into
mainfrom
cleanup/remove-updater-timeout-fixture

Conversation

@jeffwidman

@jeffwidman jeffwidman commented Aug 12, 2026

Copy link
Copy Markdown
Member

Remove the unused max-updater-run-time field from the fake job-details response.

The action does not declare or consume this field, so this only updates test data to match the current job contract.

Validated with Node 24.13.0:

  • npm run format-check
  • npm run lint-check
  • npm run typecheck
  • npm test (134 passed, 17 skipped)
  • npm run package

Packaging produced no tracked dist changes.

Related:

@jeffwidman
jeffwidman marked this pull request as ready for review August 12, 2026 02:47
@jeffwidman
jeffwidman requested a review from a team as a code owner August 12, 2026 02:47
Copilot AI balanced review requested due to automatic review settings August 12, 2026 02:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an obsolete updater timeout field from test fixture data to match the current job contract.

Changes:

  • Removes the unused max-updater-run-time fixture property.
Show a summary per file
File Description
__tests__/server/db.json Aligns the fake job response with the supported contract.

Review details

Tip

Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@jeffwidman
jeffwidman merged commit 36daae5 into main Aug 12, 2026
12 checks passed
@jeffwidman
jeffwidman deleted the cleanup/remove-updater-timeout-fixture branch August 12, 2026 15:52
@pavera pavera mentioned this pull request Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants