Adopt ESLint 10 recommended rules and ES2024 - #1749
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adopts ESLint 10 recommended rules and aligns compilation with Node 24’s ES2024 runtime.
Changes:
- Enables recommended ESLint rules and ES2024 parsing.
- Updates the TypeScript target to ES2024.
- Replaces unsafe
hasOwnPropertyusage and rebuilds the action bundle.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Targets ES2024. |
src/updater.ts |
Uses Object.hasOwn safely. |
eslint.config.mjs |
Enables recommended rules and ES2024 syntax. |
dist/main/index.js |
Updates the packaged action bundle. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/5 changed files
- Comments generated: 0
- Review effort level: Balanced
ruben-pachecocaldera
approved these changes
Aug 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@eslint/jsv10 recommended ruleshasOwnPropertycall reported by the expanded rulesValidation
npm run lint-checknpx tsc --noEmitnpm run format-checknpm testnpm run packagegit diff --check