Skip to content

JS: Recognize @fastify/rate-limit as a rate limiter #22222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cysp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JS: Recognize @fastify/rate-limit as a rate limiter #22222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion javascript/ql/lib/semmle/javascript/security/dataflow/MissingRateLimiting.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,9 @@ class RouteHandlerLimitedByRateLimiterFlexible extends RateLimitingMiddleware in
{ }

private class FastifyRateLimiter extends RateLimitingMiddleware {
FastifyRateLimiter() { this = DataFlow::moduleImport("fastify-rate-limit") }
FastifyRateLimiter() {
this = DataFlow::moduleImport(["fastify-rate-limit", "@fastify/rate-limit"])
}
}

/**
Expand Down
4 changes: 4 additions & 0 deletions javascript/ql/src/change-notes/2026-07-22-fastify-rate-limit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `js/missing-rate-limiting` query now recognizes the `@fastify/rate-limit` package as a rate limiter.
3 changes: 2 additions & 1 deletion ...script/ql/test/query-tests/Security/CWE-770/MissingRateLimit/MissingRateLimiting.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
| tst.js:64:25:64:63 | functio ... req); } | This route handler performs $@, but is not rate-limited. | tst.js:64:46:64:60 | verifyUser(req) | authorization |
| tst.js:76:25:76:53 | catchAs ... ndler1) | This route handler performs $@, but is not rate-limited. | tst.js:14:40:14:46 | login() | authorization |
| tst.js:88:24:88:40 | expensiveHandler1 | This route handler performs $@, but is not rate-limited. | tst.js:14:40:14:46 | login() | authorization |
| tst.js:112:28:112:44 | expensiveHandler1 | This route handler performs $@, but is not rate-limited. | tst.js:14:40:14:46 | login() | authorization |
| tst.js:111:28:111:44 | expensiveHandler1 | This route handler performs $@, but is not rate-limited. | tst.js:14:40:14:46 | login() | authorization |
| tst.js:116:39:116:55 | expensiveHandler1 | This route handler performs $@, but is not rate-limited. | tst.js:14:40:14:46 | login() | authorization |
8 changes: 7 additions & 1 deletion javascript/ql/test/query-tests/Security/CWE-770/MissingRateLimit/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ fastifyApp.get('/bar', expensiveHandler1);

// Fastify per-route rate limiting via config.rateLimit
const fastifyApp2 = require('fastify')();
fastifyApp2.register(require('@fastify/rate-limit'));

fastifyApp2.post('/login', {
config: {
Expand All @@ -110,3 +109,10 @@ fastifyApp2.post('/signup', {
}, expensiveHandler1); // OK - has per-route rateLimit directly in options

fastifyApp2.post('/other', expensiveHandler1); // $ Alert - no rate limiting

// rate limiting using the scoped package name
const fastifyApp3 = require('fastify')();

fastifyApp3.get('/before-rate-limit', expensiveHandler1); // $ Alert
fastifyApp3.register(require('@fastify/rate-limit'));
fastifyApp3.get('/after-rate-limit', expensiveHandler1);
Loading