Repository navigation
Improve please.sh create-sdk-artifacts - #749
Merged
Merged
Conversation
It is often necessary to update a, say, `build-installers` worktree with a newer tip commit. So far, I have done this via `--force`, which deletes and then recreates the worktree. However, I often try to replicate locally what CI runs do, e.g. checking out `build-extra` into `/usr/src/`. And that would be gone with `--force`. Also, it is highly inefficient to throw away so many files only to rewrite most of them in the identical way. So let's introduce a `--reuse` option that will allow to do exactly that: It expects an already-initialized directory, update it as desired, with a `git reset --hard` to finish the update. This option implies `--keep-worktree`. Signed-off-by: Johannes Schindelin <[email protected]>
Sometimes I am operating from a checkout that can not easily be updated, e.g. because pulling `main` from git-for-windows/git-sdk-64 would update the MSYS2 runtime or Git or any other executable, really, that I am still using. In those cases I still might need to create an SDK artifact from the most recent commit. The new `--head=<revision>` option allows that. Signed-off-by: Johannes Schindelin <[email protected]>
The script so far assumes that the provided `--sdk=<path>` refers to the main worktree. However, that is not always the case; I might even have a bare, partial clone lying around that I need to use to initialize -- quickly! -- an SDK artifact. Let's allow for that. Signed-off-by: Johannes Schindelin <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on resolving issues that would prevent this coming Monday's release of Git for Windows v2.56.0 (which were addressed by #748, but I had to investigate a problem locally that eventually pointed to a successful workflow job to be re-run), In need to replicate scenarios in CI runs locally, which the
please.shscript did not easily support.Here are the changes to allow reusing an existing (even detached) output directory, to specify exactly which
git-sdk-*revision to build from, and to work with bare clones of thegit-sdk-*repository.