Repository navigation
Conversation
1 task done
we've not supported any OS older than Vista in a decade. We don't need to keep the code to support these ancient Versions around. Signed-off-by: Matthias Aßhauer <[email protected]>
Since commit c81b9b3 (installer: offer to terminate GPG's services, if still running, 2021-08-19) the installer tries to terminate GPGs daemon processes, but nowadays there are more potentially running daemon processes than just gpg-agent and scdaemon. Since these are also automatically started on demand by GPG, we can also end them to install a new version. This fixes git-for-windows/git#6416 Signed-off-by: Matthias Aßhauer <[email protected]>
GPG offers the `gpgconf --kill` command that can end GPG daemon processes more gently than our current `TerminateProcessByID`. It even has an option to terminate all GPG daemon processes, that should even terminate future daemons that have names we don't know yet. Use that and fall back to `TerminateProcessByID` only if that fails. Signed-off-by: Matthias Aßhauer <[email protected]>
rimrul
force-pushed
the
gpg-daemon-cleanup
branch
from
September 18, 2026 09:03
9f5df40 to
fc0afe6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.