Skip to content

mingit: ship BusyBox as sh.exe in the BusyBox-based MinGit #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zcsizmadia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mingit: ship BusyBox as sh.exe in the BusyBox-based MinGit #746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mingit/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,17 @@ $BIN_DIR/busybox.exe
esac

rm "$SCRIPT_PATH/root/$BIN_DIR"/busybox.exe

# Ship BusyBox as sh.exe, too. Git looks up `sh` via the PATH and
# uses the result as argv[0] (see `git_shell_path()`). Without an
# sh.exe, the BusyBox fallback in compat/mingw.c returns the path
# of busybox.exe itself, and BusyBox then takes `-c` for the name of
# an applet ("-c: applet not found"). This breaks `!` aliases,
# clones from local paths and every other code path that runs a
# shell command. BusyBox picks the applet from its own file name,
# so a copy named sh.exe acts as `sh` without extra indirection.
cp "/$BIN_DIR"/busybox.exe "$SCRIPT_PATH/root/$BIN_DIR"/sh.exe ||
die "Could not copy busybox.exe to sh.exe"
esac

test ! -f "$TARGET" || rm "$TARGET" || die "Could not remove $TARGET"
Expand Down