Use released minitest-reporters gem instead of git source#5
Open
gillisd wants to merge 1 commit into
Open
Conversation
The released minitest-reporters 1.8.0 now depends on minitest (>= 5.0, < 7), so it supports this project's minitest ~> 6.0. That constraint was the reason the gem was pinned to the git source; it is fixed in the release, so switch to the published gem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches
minitest-reportersfrom the GitHub git source back to the published RubyGems release.Why
The gem was pinned to the git source because older released versions capped
minitest < 6, while this project usesminitest ~> 6.0. The releasedminitest-reporters 1.8.0now depends onminitest (>= 5.0, < 7)(verified against the RubyGems remote spec), so the published gem supports our minitest version. The reason for the git pin is resolved in the release.Verification
Gemfile.lockregenerated from scratch (bundle install); noGITsource remains andminitest-reporters 1.8.0now resolves from RubyGems.bundle exec rakesuite passes:Note:
Gemfile.lockis gitignored (standard for a gem), so only theGemfilechange is committed.