Skip to content

Add agent harness: AGENTS.md, review skill, site check CI - #5

Merged
ghostleek merged 4 commits into
masterfrom
claude/agent-harness
Oct 7, 2026
Merged

ghostleek merged 4 commits into
masterfrom
claude/agent-harness

Conversation

@ghostleek

Copy link
Copy Markdown
Owner

Makes the repo easier for coding agents (and reviewers) to work in. No site content is changed.

What's added

  • AGENTS.md (+ CLAUDE.md = @AGENTS.md): where things live, how to preview (python3 -m http.server 8000), and rules: never touch CNAME, case-sensitive paths, alt text, image size, Font Awesome 5 prefixes, nothing private in the repo.
  • scripts/check_site.py: a check that uses only the Python standard library. It fails on missing local href/src targets (including case mismatches like pic04.jpg vs pic04.JPG), #anchor links with no matching id, <img> without alt, broken CSS url(), and a malformed CNAME. HTML comments are ignored.
  • .github/workflows/ci.yml: runs the check on PRs and on pushes to master (contents: read).
  • .github/skills/code-review/SKILL.md: a review guide based on this repo's own fix commits (case-sensitive image paths, blank FA icons, a private PDF that was committed, 7 MB photos, dangling gapminder.html/iframe embeds, nav label drift).

Verification

  • python3 scripts/check_site.py passes on current master.
  • I broke things on purpose (wrong-case image path, a #works anchor that doesn't exist, a removed alt, https:// in CNAME, wrong-case bg.JPG in main.css). All five were reported with exit 1, and I then reverted them.
  • python3 -m http.server serves / and /images/pic04.JPG with status 200.

Notes (not fixed here)

  • images/bg.jpg (2.9 MB), pic05.JPG (2.7 MB) and pic04.JPG (1.6 MB) are large.
  • Two Adobe Lightroom icon links have an empty label, so screen readers get no name for them.
  • .DS_Store files are committed, and there's no .gitignore.
  • .github/dependabot.yml has an empty package-ecosystem.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WZKhoAfa499EJsRM8WjrJq


Generated by Claude Code

- AGENTS.md (+ CLAUDE.md importing it): layout, local preview, rules
  (never touch CNAME, case-sensitive paths, alt text, image size).
- scripts/check_site.py: stdlib-only check for missing local files,
  dangling #anchors, img without alt, broken CSS url(), malformed CNAME.
- .github/workflows/ci.yml runs it on PRs and pushes to master.
- .github/skills/code-review/SKILL.md: review guide built from this
  repo's own fix history.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01WZKhoAfa499EJsRM8WjrJq
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: af536c16-bd76-4b85-ba40-8eb8ea4e13b9
📥 Commits

Reviewing files that changed from the base of the PR and between 263d180 and ba4839c.

📒 Files selected for processing (6)
  • .github/skills/code-review/SKILL.md
  • .github/workflows/ci.yml
  • AGENTS.md
  • CLAUDE.md
  • CNAME
  • scripts/check_site.py
 ________________________________
< Goodbye, diff induced despair. >
 --------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The checker has unresolved CNAME and path-validation issues.

Review effort: Lite
Findings: 2 Medium severity

Open (2)
What changed in this PR

Adds agent guidance, a static-site checker, CI validation, and repository-specific review instructions.

Changes:

  • Added AGENTS.md and CLAUDE.md.
  • Added link, asset, anchor, CSS, and CNAME validation.
  • Added GitHub Actions CI.
  • Added a code-review skill guide.
File Description
scripts/​check_site.py Static-site validation logic
CLAUDE.md References AGENTS.md
AGENTS.md Agent workflow and repository rules
.github/​workflows/​ci.yml Runs site validation
.github/​skills/​code-review/​SKILL.md Repository-specific review guidance

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/check_site.py Resolved
Comment thread scripts/check_site.py Resolved
claude and others added 2 commits October 4, 2026 06:31
os.path.exists ignores case on default macOS volumes, so a wrong-case
asset path passed locally and 404'd on GitHub Pages. Compare each path
component against the real directory entries instead.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01WZKhoAfa499EJsRM8WjrJq
Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copy link
Copy Markdown
Owner Author

check-site is failing on 08222e3. The stricter CNAME check is doing its job: CNAME on master still lists two hostnames (leekahhow.com and www.leekahhow.com), so python3 scripts/check_site.py exits 1 with "CNAME must hold one bare hostname only". I reproduced this locally. It isn't a flake, and re-running won't help.

To fix it, CNAME needs to list a single hostname. Which one is the owner's call, since it decides which domain GitHub Pages serves. I couldn't check the configured Pages domain from here. The suggestion is leekahhow.com: GitHub Pages redirects www to the apex domain when DNS has both records.

Separately, the error text "Restore it from origin/master" is misleading now, because master holds the two-line file. It can be reworded in the same commit as the CNAME change.


Generated by Claude Code

GitHub Pages uses one custom domain per site; www.leekahhow.com
redirects to it automatically. Also drop trailing spaces and reword
the CNAME check's error message (master no longer has a valid copy
to restore from).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01WZKhoAfa499EJsRM8WjrJq
@ghostleek
ghostleek marked this pull request as ready for review October 7, 2026 03:40
@ghostleek
ghostleek merged commit 2dc40d5 into master Oct 7, 2026
4 checks passed
@ghostleek
ghostleek deleted the claude/agent-harness branch October 7, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants