Repository navigation
Reuse an open winget Package Request on rerun - #286
Merged
Merged
Conversation
Every run files a "[Package Request]: getSigit.siGitCode <version>" issue before opening the manifest PR, so each rerun after a failure added another one. 1.7.7 ended up with three. The step now looks for the issue account's open request with that exact title and reuses it. It only files a new one when there isn't one, and it skips the wait before the PR when the issue is reused. Co-Authored-By: Claude Opus 5.5 <[email protected]>
#282 moved npm/, pypi/ and nuget/ under packaging/, which the filter already ignores. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
siGit Code Review couldn't finish this review: the model service was unavailable. Mention @sigit-code-review to try again. Automated review by siGit Code Review · commit 99acda7 · see the review dashboard |
setoelkahfi
approved these changes
Oct 29, 2026
paydii
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-winget files a "[Package Request]: getSigit.siGitCode " issue on every run, then opens the manifest PR that resolves it. So a rerun after a failed run filed the request again. That's how 1.7.7 got three: #465285 and #465415 from the failed run, then #465691 from the good one.
The issue step now looks up the issue account's open request with that exact title. It reuses one if it exists and only files a new one if it doesn't.
gh issue list --searchnarrows the results and a jq match on the full title makes the call, so "1.7" can't match a "1.7.7" request. If the lookup itself errors,set -efails the step instead of filing a duplicate. The pause between the issue and the PR is skipped when the issue is reused, since it's already old by then.I ran the lookup against winget-pkgs. With
--author setoelkahfiit finds #465691. With an account that has no open request it returns nothing, and a title that only matches as a prefix also returns nothing.The second commit removes the
!npm/**,!pypi/**and!nuget/**lines from the CI path filter. Those directories moved underpackaging/in #282, and!packaging/**already covers them.This PR doesn't stop a rerun from opening a second manifest PR if wingetcreate already opened one. That didn't happen with 1.7.7, because the failed run never got that far.