Repository navigation
Fail the winget existence check on an unexpected status, and group the workflow names - #284
Merged
Merged
Conversation
The v1.7.7 run hit a GitHub outage while checking whether getSigit.siGitCode is in winget-pkgs. The check counted any failed `gh api` call as "not there", so it took the new-package path and opened a bogus Package Request (microsoft/winget-pkgs#465415) for a package that has been there since 1.7.4. It now branches on the status code the way the NuGet and PyPI checks do: 200 means update, 404 means new package, and anything else fails the job before an issue or PR is opened, so a rerun is safe. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Every release workflow is now named "Release <channel>", so the Actions sidebar lists them together after CI. Only the display names change. The filenames stay, so release-github's dispatches, the CI badge and the trusted publishers, which all key on the file, still work. Co-Authored-By: Claude Opus 5.5 <[email protected]>
![sigit-code-review[bot]](https://avatars.githubusercontent.com/in/3492899?s=60&v=4){kind=small}
There was a problem hiding this comment.
This change updates the winget release workflow to branch on the HTTP status code when checking for an existing package, ensuring only 200 (found) and 404 (not found) are handled, and any other status fails the job to prevent incorrect submissions during outages or API errors. The workflow names for all release jobs are also standardized to 'Release ' for better grouping in the Actions sidebar. The logic for the winget check now matches the NuGet and PyPI checks, and the workflow name changes are cosmetic and do not affect workflow triggers or concurrency.
Automated review by siGit Code Review · commit de3abff · see the review dashboard
setoelkahfi
approved these changes
Oct 29, 2026
paydii
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.7.7 winget run (40931980522) landed in the middle of a GitHub outage. The "already in winget-pkgs" step counted any failed
gh apicall as "not found". So it took the new-package path for getSigit.siGitCode, which has been in winget-pkgs since 1.7.4, and opened a bogus Package Request, microsoft/winget-pkgs#465415.The check now branches on the status code, the same way the NuGet and PyPI checks do. 200 means update and 404 means new package. Anything else fails the job before an issue or PR gets opened, so a rerun is safe.
The second commit renames the release workflows to "Release " so they sit together in the Actions sidebar after CI. Only the
name:values change. The filenames stay, so release-github's dispatches, the CI badge and the trusted publishers are unaffected. Theconcurrencykeys come fromgithub.workflow, so those change too, which is harmless. #281 gets the matching "CI Linux glibc floor" rename on its own branch.I tested the new check locally. The real manifests path returns 200 and a made-up one returns 404. A bad host (000) and a bad token (401) both exit 1.
After this merges I'll close #465415 and re-dispatch release-winget for v1.7.7.