Repository navigation
chore(sentry): Update SDK to v1.0.0-alpha.1 - #729
Merged
Merged
Conversation
mjq
force-pushed
the
mjq/use-latest-sentry-new-scopes-api
branch
from
October 14, 2026 14:00
f44c888 to
b10721a
Compare
giortzisg
approved these changes
Oct 15, 2026
giortzisg
left a comment
giortzisg
left a comment
There was a problem hiding this comment.
Overall looks good, thanks for trying out the new API 🙏. Just left a small comment.
mjq
force-pushed
the
mjq/use-latest-sentry-new-scopes-api
branch
from
October 19, 2026 14:51
b10721a to
6fad880
Compare
mjq
changed the title
mjq
marked this pull request as ready for review
October 19, 2026 14:52
nikkikapadia
approved these changes
Oct 19, 2026
skaasten
reviewed
Oct 19, 2026
| err = server.ListenAndServe() | ||
| if err != nil && err != http.ErrServerClosed { | ||
| rootHub.CaptureException(err) | ||
| sentry.CaptureException(context.Background(), err) |
There was a problem hiding this comment.
This seems unexpected - would we not use the same context for these calls vs making a new empty one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new scopes API, which replaces the old
Hub-based one.This new API is much more straightforward to use concurrently, so we can get rid of the forbidigo rules disallowing the SDK's concurrency-unsafe methods.