Repository navigation
fix(cli): Reject custom header values that fetch cannot send - #1604
Merged
Merged
Conversation
A custom header value with emoji, other non-Latin-1 characters, CR, LF, or NUL made undici's Headers.set() throw an opaque TypeError at request time (CLI-31G). Validate values from SENTRY_CUSTOM_HEADERS and SentryOptions.headers up front and throw a ConfigError that names the header without echoing its value. Ported from getsentry/cli#1660. Co-Authored-By: BYK <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
approved these changes
Oct 23, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom header value with emoji, other non-Latin-1 characters, CR, LF, or NUL made undici's
Headers.set()throw an opaqueTypeError: Cannot convert argument to a ByteStringat request time (CLI-31G).Values from
SENTRY_CUSTOM_HEADERSandSentryOptions.headersare now validated up front and rejected with aConfigErrorthat names the header but never echoes its value, since these headers often carry proxy credentials.The e2e redaction test used a CR in a header to reach the unexpected-error path. It now asserts the config error instead; redaction of unexpected errors stays covered by the unit tests.
Ported from getsentry/cli#1660, which is being closed with the repo archive.
via BYK.
--
View Junior Session in Sentry