Repository navigation
fix(cli): narrow metric alert dataset before mapping - #1599
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
approved these changes
Oct 22, 2026
BYK
marked this pull request as ready for review
October 22, 2026 15:37
betegon
added a commit
that referenced
this pull request
Oct 23, 2026
Moves the independent docs Worker from [cli-init-api at f3b32b49](https://github.com/getsentry/cli-init-api/tree/f3b32b49ebaa5eb13378e1e5ab9f05be2f39ba5d/apps/docs-mcp) into `apps/docs-mcp` so it can be maintained independently of Init Server. Docs MCP follows the shared Wrangler 4.151.3 catalog introduced by #1598; obsolete Wrangler dependencies and Miniflare overrides are removed. This PR targets `main` and preserves the imported Worker behavior. Preserves the `docs-mcp` Worker name, private service-binding endpoints, tools, and runtime configuration. Adds workspace validation and documents the later Workers Builds handoff, including repository-root install and build commands. No Worker deployment or Cloudflare connection changes are included; the source copy remains until that handoff. Uses patched Hono 4.13.13 for [GHSA-5r4p-p66f-jhc7](GHSA-5r4p-p66f-jhc7). Updates the existing `express-rate-limit` override to `ip-address` 10.7.4 for [GHSA-rxp7-6hxx-x8q5](GHSA-rxp7-6hxx-x8q5), published during review. Keeps AI SDK 5/Sentry 10, supplies OpenRouter's missing provider dependency, and anchors the main MCP's generated Sentry imports to its own SDK so both apps build together. Frozen install, full typecheck/build, MCP suites, 47 docs tests, formatting, and docs links pass. Local Wrangler 4.151.3 passes health, MCP initialization/tool listing, repeated successful `search-docs` calls, and internal payload validation; no model calls or deployment were performed. Repository lint passes after #1599. Previous full-suite runs hit unrelated CLI test failures (macOS musl detection, unavailable Xcode tooling, and issue unlinking). Includes one small normalization correction for the blocking CodeQL check: strip an absolute URL prefix only for the exact docs origin or its slash-delimited prefix. Documented path and URL inputs keep the same output; regression tests cover lookalike hosts and userinfo prefixes. Redirect handling is unchanged. Existing tool-error and input-limit issues remain separate follow-ups in #1600 and #1601.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
typescript/no-base-to-stringerror inalerts.tsthat blocks repository and CLI lint, including #1598. Reuse the existingpickDetectorStringhelper so supported dataset strings and native monitor edit round-trips stay unchanged.Validated with 189 focused alert tests, workspace typechecks, repository/CLI lint, and CLI policy checks. The full suite still hits existing CLI failures in the macOS install-script fixture and missing Xcode
actool; all non-CLI suites pass.