Repository navigation
Conversation
Retain event package metadata and support bounded exact-name selection through the existing resource and issue readers. Include selected versions with supplied Markdown and local formatting without extra API requests. Fixes getsentry#1292 Co-Authored-By: GPT-6 (Codex) <[email protected]>
mr-danya
marked this pull request as ready for review
September 8, 2026 01:46
Merge upstream/main and retain package selection in the new structured issue responses as well as Markdown fallback. Share selection logic and cover both response formats through the tool and MCP boundaries. Co-Authored-By: GPT-6 (Codex) <[email protected]>
Preserve package-selection test imports alongside upstream tool failure telemetry tests and the latest issue-details replay limits. Co-Authored-By: GPT-6 (Codex) <[email protected]>
Preserve selected event package versions alongside suspect commit output and adapt package-selection fixtures to numeric issue event endpoints. Co-Authored-By: GPT-6 (Codex) <[email protected]>
Preserve package selection alongside updated resource telemetry and nullable event context documentation. Co-Authored-By: GPT-6 (Codex) <[email protected]>
Preserve selected package versions with experimental structured issue details and locally formatted event bodies. Regenerate definitions and update response snapshots for the upstream formatting contract. Co-Authored-By: GPT-6 (Codex) <[email protected]>
|
@mr-danya is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
BYK
requested changes
Oct 21, 2026
|
|
||
| return { | ||
| metadataAvailable: true, | ||
| packages: [...new Set(packageNames)].map((name) => { |
Member
There was a problem hiding this comment.
Suggested change
| packages: [...new Set(packageNames)].map((name) => { | |
| packages: Array.from(new Set(packageNames), (name) => { |
| return { | ||
| metadataAvailable: true, | ||
| packages: [...new Set(packageNames)].map((name) => { | ||
| const version = Object.hasOwn(packages, name) |
Member
There was a problem hiding this comment.
packages should be a Map I guess if we are doing this?
| const version = Object.hasOwn(packages, name) | ||
| ? packages[name] | ||
| : undefined; | ||
| if (version === undefined || !version?.trim()) { |
Member
There was a problem hiding this comment.
First check is redundant.
Suggested change
| if (version === undefined || !version?.trim()) { | |
| if (!version?.trim()) { |
| if (version === undefined || !version?.trim()) { | ||
| return { | ||
| name, | ||
| status: version === undefined ? "not_listed" : "version_not_recorded", |
Member
There was a problem hiding this comment.
Well, do version === undefined early on and record it? Then you can probably reduce this to a single return {...} statement with 2 ternary statements in it.
Comment on lines
+1985
to
+1993
| const value = | ||
| entry.status === "recorded" | ||
| ? entry.truncated | ||
| ? `${entry.version}… (truncated)` | ||
| : entry.version | ||
| : entry.status === "not_listed" | ||
| ? "Not listed in this event's package metadata" | ||
| : "Version not recorded"; | ||
| output += `- ${formatPackageText(entry.name)}: ${formatPackageText(value)}\n`; |
Member
There was a problem hiding this comment.
These nested ternaries are blowing my mind. I feel like this calls for a switch block to be clear?
Comment on lines
+1998
to
+2004
| function formatPackageText(value: string): string { | ||
| return value | ||
| .replace(/[\r\n\t]/g, " ") | ||
| .replace(/&/g, "&") | ||
| .replace(/</g, "<") | ||
| .replace(/([\\`*_[\]|>])/g, "\\$1"); | ||
| } |
Member
There was a problem hiding this comment.
What is this doing? Don't we already have proper markdown/HTML escaping and building blocks in the repo?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional
packageNamesselection to exact-event reads throughget_sentry_resourceandget_issue_details, so dependency compatibility diagnosis can use versions recorded with the event. Returns up to 10 selected packages instructuredContentwhen Sentry supplies JSON, and in Markdown fallback responses, with distinct states for unavailable metadata and unlisted packages and bounded version lengths. Calls without a selection retain their existing output, with no additional API requests.Fixes #1292.
Before / After