Skip to content

fix: Use zstd for bool and int attributes - #8578

Open
elramen wants to merge 1 commit into
masterfrom
elramen-zstd
Open

elramen wants to merge 1 commit into
masterfrom
elramen-zstd

Conversation

@elramen

@elramen elramen commented Oct 20, 2026

Copy link
Copy Markdown
Member

https://sentry.slack.com/archives/C039ZGT5K/p1792104186179979

Please confirm that it's safe to have a mix of lz4 and zstd mid-transition.

@elramen
elramen requested review from a team as code owners October 20, 2026 21:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 53539c5. Configure here.

)
for table in local_tables
for column in _columns(None)
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollback does not restore original codec

Low Severity

backwards_ops rebuilds the columns with no codec clause. ClickHouse MODIFY COLUMN that omits CODEC keeps the current codec, so a rollback does not restore the original LZ4 default on attributes_bool and attributes_int.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 53539c5. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant