Repository navigation
feat(eap-items): Point eap_items_dlq_replay at eap_items_2 tables - #8575
Merged
Merged
Conversation
Co-Authored-By: Ryan Broughan <[email protected]>
tryangul
enabled auto-merge (squash)
October 20, 2026 20:20
MeredithAnya
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repoints the existing
eap_items_dlq_replaystorage fromeap_items_1_local/eap_items_1_disttoeap_items_2_local/eap_items_2_dist. The maineap-items-consumerin us, de and s4s2 now writeseap_items_2, so DLQ replays should land there too.The schema and
UUIDColumnProcessorcolumns are synced witheap_items_2, which addsconversation_id,session_idandai_conversation_id. They had drifted from the primary storage. The storage name, the input topic (snuba-dead-letter-items) and the lack of adlq_topicdon't change. Because the name doesn't change,eap_items_dlq_grace_period_minstill has no entry for it, so replayed rows aren't DLQ'd again.This applies everywhere the replay consumer runs with the default storage. Any replay consumer that's running when this deploys starts writing
eap_items_2on its next restart. No ops change is needed for regions that use the default storage. This replaces #8570, which added a separateeap_items_2_dlq_replaystorage instead.via Ryan Broughan.
--
View Junior Session [Sentry]