Repository navigation
Conversation
tryangul
commented
Oct 19, 2026
| metadata: &KafkaMessageMetadata, | ||
| config: &ProcessorConfig, | ||
| ) -> anyhow::Result<ProcessedItem> { | ||
| ) -> anyhow::Result<Option<ProcessedItem>> { |
Contributor
Author
There was a problem hiding this comment.
Note: Result<Option< is a bit of a code smell, but this keeps the diff tight and unblocks us in the interest of time / effort (things will start aging out the the DLQ in a little over 24 hours)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-adds the out-of-range timestamp drop removed in #8222, but bounded by item retention instead of a flat 30 days.
How
eap_items_drop_invalid_timestampsoption is back, defaultfalseretention_daysor >7d in the future, before the age DLQ check*.dropped_out_of_range_timestamp{reason, item_type}metrics restored.reason:past_ts|future_tsmatchesdlqed_prior_partitionout_of_valid_interval_secsrewritten for readability. Boundaries are the same (exactly-at-retention / exactly +7d are kept)Why
Notes
Utc::now()and read the option independently. Different lag means a message can be dropped by one and kept by the other around the flip or right at a boundary. Should be negligible.Links