Repository navigation
fix(metrics): drop duplicate snuba prefix from remaining metrics - #8564
Merged
ElioDiNino merged 1 commit intoOct 19, 2026
Conversation
The global metrics backend already prefixes everything with `snuba.`, so wrappers named `snuba.delete`, `snuba.state` and `snuba.validation` emitted `snuba.snuba.*`, and the read-through cache fail-open counter repeated its wrapper prefix. Also removes the unused attribution wrapper. Refs EAP-851
tryangul
reviewed
Oct 19, 2026
tryangul
approved these changes
Oct 19, 2026
ElioDiNino
enabled auto-merge (squash)
October 19, 2026 18:07
ElioDiNino
deleted the
eliodinino/eap-851-drop-duplicate-snuba-prefix-from-remaining-metrics
branch
October 19, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8526. The global metrics backend already prefixes everything with
snuba., so these still emitted doubled names:snuba.snuba.delete.max_rows_exceededsnuba.delete.max_rows_exceededsnuba.snuba.delete.delete_query.delete_ignoredsnuba.delete.delete_query.delete_ignoredsnuba.snuba.delete.delete_query.delivery_callbacksnuba.delete.delete_query.delivery_callbacksnuba.snuba.state.record_query.delivery_callbacksnuba.state.record_query.delivery_callbacksnuba.snuba.validation.referrer_mismatchsnuba.validation.referrer_mismatchsnuba.read_through_cache.snuba.read_through_cache.fail_opensnuba.read_through_cache.fail_openAlso removes the
snuba.attributionmetrics wrapper, which nothing used.Heads up: this renames metrics. No alerts reference them, but two dashboard widgets need updating after deploy. They're tracked as a checklist in the ticket.
No test asserts on these metric names.
Refs EAP-851