feat(flask): Gate user identity behind data_collection config#6859
Open
ericapisani wants to merge 1 commit into
Open
feat(flask): Gate user identity behind data_collection config#6859ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Apply data_collection.user_info filtering to Flask's login-user identity capture, mirroring the WSGI/ASGI changes: gate user population on request start, event user data, and span user.* attributes behind data_collection, falling back to send_default_pii when data_collection is not configured. Add parametrized end-to-end tests for Flask covering data_collection precedence over send_default_pii for both error events and span attributes. Ref PY-2586 Ref #6746
Contributor
Codecov Results 📊✅ 94903 passed | ⏭️ 6338 skipped | Total: 101241 | Pass Rate: 93.74% | Execution Time: 335m 28s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2483 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.70% 89.75% +0.05%
==========================================
Files 193 193 —
Lines 24030 24223 +193
Branches 8348 8528 +180
==========================================
+ Hits 21555 21740 +185
- Misses 2475 2483 +8
- Partials 1384 1380 -4Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply data_collection.user_info filtering to Flask's login-user
identity capture, mirroring the WSGI/ASGI changes: gate user
population on request start, event user data, and span user.*
attributes behind data_collection, falling back to
send_default_pii when data_collection is not configured.
Add parametrized end-to-end tests for Flask covering
data_collection precedence over send_default_pii for both error
events and span attributes.
Ref PY-2586
Ref #6746