Skip to content

fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle#6844

Merged
alexander-alderman-webb merged 30 commits into
masterfrom
webb/no-op-ctx-mgr
Jul 22, 2026
Merged

fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle#6844
alexander-alderman-webb merged 30 commits into
masterfrom
webb/no-op-ctx-mgr

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Do not set a transaction-based span on the scope when span streaming. The early returns in start_span() and start_transaction() are not sufficient as they return NoOpSpan when span streaming, and NoOpSpan still mutates scopes on __enter__() and __exit__().

Issues

Reminders

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

92197 passed | ⏭️ 6304 skipped | Total: 98501 | Pass Rate: 93.6% | Execution Time: 311m 25s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2478 uncovered lines.
✅ Project coverage is 89.69%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.69%    89.69%        —%
==========================================
  Files          193       193         —
  Lines        24033     24039        +6
  Branches      8350      8354        +4
==========================================
+ Hits         21555     21561        +6
- Misses        2478      2478         —
- Partials      1387      1387         —

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title fix(tracing): Stop setting NoOpSpan on scope fix(tracing): Stop setting NoOpSpan on scope in the streaming trace lifecycle Jul 20, 2026
@alexander-alderman-webb
alexander-alderman-webb changed the base branch from master to webb/no-op-start-transaction July 21, 2026 13:10
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 21, 2026 14:46
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 21, 2026 14:46
Base automatically changed from webb/no-op-start-transaction to master July 22, 2026 07:56
@alexander-alderman-webb
alexander-alderman-webb merged commit 4524b65 into master Jul 22, 2026
141 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/no-op-ctx-mgr branch July 22, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants