-
-
Notifications
You must be signed in to change notification settings - Fork 5
chore(deps): update Dotnet SDK to v6.10.0 #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+6
−11
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3fc09af
chore: update dependencies/Sentry.properties to 6.10.0
web-flow 4785f72
docs: Drop the Logs opt-in from the send-logs sample
vaind ade5ca3
Configure Sentry client with DSN and debug mode
vaind 0870819
docs: Fold the Logs opt-in note into the Write-SentryLog entry
vaind 3df2afd
docs: Drop the Experimental breaking-change entry
vaind 4def664
docs: Credit #133 on the Write-SentryLog entry
vaind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| version = 6.5.0 | ||
| version = 6.10.0 | ||
| repo = https://github.com/getsentry/sentry-dotnet | ||
| license = MIT | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,11 +14,10 @@ | |
| # Import the Sentry module. In your code, you would just use `Import-Module Sentry`. | ||
| Import-Module $PSScriptRoot/../modules/Sentry/Sentry.psd1 | ||
|
|
||
| # Start the Sentry client. Set EnableLogs = $true to opt in to Logs. | ||
| # Start the Sentry client. | ||
| Start-Sentry { | ||
| $_.Dsn = 'https://[email protected]/4508073336176640' | ||
| $_.Debug = $true | ||
| $_.EnableLogs = $true | ||
| } | ||
|
|
||
| try { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The dependency upgrade to Sentry .NET SDK v6.8.0 may break reflection-based access to internal APIs like
HttpTransportBase.ProcessEnvelope, causing initialization failures.Severity: HIGH
Suggested Fix
Verify that the internal Sentry .NET SDK APIs accessed via reflection still exist and have the same signatures in v6.8.0. If they have changed, update the reflection code in
SynchronousTransport.ps1andNew-HttpTransport.ps1to match the new API. Consider adding tests that validate the reflection against the new SDK version to prevent future breakages.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.