feat: Expose StringOrRegex discriminator - #5543
Open
limbonaut wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Codex <[email protected]>
Author
|
Can’t tag you for review, so I’ll just ping you, @jamescrosswell and @Flash0ver 🙂 |
jamescrosswell
requested changes
Sep 7, 2026
jamescrosswell
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @limbonaut - Generally OK with the change but I think we could simplify it. I don't think we need to add a new enum to do what you want.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
==========================================
- Coverage 74.72% 74.70% -0.02%
==========================================
Files 515 515
Lines 18948 18949 +1
Branches 3696 3696
==========================================
- Hits 14158 14156 -2
- Misses 3906 3910 +4
+ Partials 884 883 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Codex <[email protected]>
jamescrosswell
self-requested a review
September 7, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes whether a
StringOrRegexcontains a literal string or a regular expression through a new public discriminator. This allows SDK integrations to preserve trace propagation target semantics across interop boundaries without reflection or treating regex patterns as literal strings.The Godot SDK reads these targets from the .NET SDK and passes them to its native layer. Without this discriminator, it cannot tell a plain string from a regex. Reflection is not an option because Godot supports AOT on iOS, while treating regex patterns as strings would be incorrect.