Repository navigation
fix(test): Add feature_id to autofix response fixtures - #134
Merged
Merged
Conversation
The a47f626 schema regen picked up `feature_id` as a required field on the autofix POST response, matching what the Sentry endpoint now returns. The typecheck and smoke test fixtures still built the old two-field response, so `pnpm typecheck` failed with TS2741 and both validator smoke tests rejected the fixture. Co-Authored-By: Burak Yigit Kaya <[email protected]>
sentry-junior
Bot
requested review from
BYK,
MathurAditya724 and
betegon
as code owners
November 6, 2026 23:29
BYK
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas failed Build and Build (Node LTS) since a47f626.What broke: the a47f626 regen of
openapi-derefed.jsonaddedfeature_idto the autofix POST response and made it required. That matches Sentry:GroupAutofixEndpoint(src/sentry/seer/endpoints/group_ai_autofix.py) always returns{run_id, sentry_run_id, feature_id}, and the API docs example includes"feature_id": "autofix". The schema is correct. The test fixtures still built the old two-field response, which caused:pnpm typecheck:test/typecheck.ts(33,7): error TS2741: Property 'feature_id' is missingpnpm test: the two "runtime validator entry points" smoke tests (Valibot and Zod) rejected the fixture.Fix: add
feature_id: "autofix"to both fixtures. No test or check is skipped or loosened; the negativerun_id: "42"cases are unchanged.Verification: I ran the Build workflow steps locally on Node 22.23 from a clean checkout of
mainplus this change. Node LTS wasn't available locally, so CI covers that job.pnpm install --frozen-lockfile: passpnpm build: passpnpm typecheck: pass. Without the change it reports 1 TS error.pnpm test: 51 files and 635 tests pass. Without the change,smoke.test.tshas 2 failures.npm pack --dry-run: passUnblocks CI on #133.
via @BYK.
--
View Session [Sentry]