ref(perfetto): Rework perfetto conversions#6243
Open
Dav1dde wants to merge 2 commits into
Open
Conversation
Dav1dde
force-pushed
the
dav1d/improve-perfetto
branch
from
July 16, 2026 18:34
f90f5ae to
a0224f8
Compare
Dav1dde
force-pushed
the
dav1d/improve-perfetto
branch
from
July 16, 2026 19:11
a0224f8 to
4bcb84d
Compare
Dav1dde
force-pushed
the
dav1d/improve-perfetto
branch
from
July 16, 2026 19:23
4bcb84d to
fade150
Compare
loewenheim
requested changes
Jul 17, 2026
loewenheim
left a comment
Contributor
There was a problem hiding this comment.
Looks very good, just some minor things.
| pub const CLOCK_BOOTTIME: u32 = 6; | ||
|
|
||
| /// Maximum number of raw samples we collect from a Perfetto trace before | ||
| /// bailing out. At 100 Hz across multiple threads, a 66-second chunk |
Contributor
There was a problem hiding this comment.
Why is a 66-second chunk relevant in particular?
Member
Author
There was a problem hiding this comment.
Presumably due to the max profile length we support:
/// For continuous profiles, each chunk can be at most 1 minute.
/// In certain circumstances (e.g. high cpu load) the profiler
/// the profiler may be stopped slightly after 60, hence here we
/// give it a bit more room to handle such cases (66 instead of 60)
const MAX_PROFILE_CHUNK_DURATION: Duration = Duration::from_secs(66);
loewenheim
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No (or very minimal) functional changes intended.
HashTableuse for images, frames and stacks, instead of just frames.HashTablereferencing strings already allocated elsewhere.builder types, used to build up our own sample format.cachetypes, used just to cache data for a single sequence idInternTablesis no longer also abused for caches.StackIdandFrameIdnew-type wrapper instead of passing indices around, may prevent a bug at some point.ResolvedFrame)And yes there are some off-by-ones when it comes to the limits, they don't matter, if it messes with someone's OCD, I can fix them.