Repository navigation
ci: Fix CodeQL workflow findings - #2643
Merged
Merged
Conversation
Co-Authored-By: Joshua Li <[email protected]>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 918df15. Configure here.
joshuarli
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes what CodeQL's default code-scanning suites (python + actions) report on current
main. The Python suite has no findings. The actions suite has 7:actions/cache-poisoning/code-injectioninpre-commit.yml:${{ steps.changes.outputs.all_files }}was expanded straight into therun:script. On a push tomain, a crafted file name could inject shell into a job that writes the default-branch cache. The value now goes through an env var, andxargs -d '\n'keeps file names intact.actions/missing-workflow-permissions(6) inauto-merge,build(×2),image,pre-commitandtest: each now sets explicitGITHUB_TOKENpermissions:contents: readeverywhere.pull-requests: writefor auto-merge'sgh pr review --approve.packages: writefor the ghcr.io push inimage.pull-requests: readfordorny/paths-filterinpre-commit.collect-and-deploykeeps its existing job-levelid-token: write.After the change, a local CodeQL 2.27.3 run against this branch (
actions-code-scanning.qls) reports 0 results.I couldn't read this repo's alert list. The GitHub App lacks
security_events: read, so this is based on a fresh local scan, not the open alerts. Alerts that no longer reproduce onmainshould close on the next default-setup scan.via @joshuarli.
--
View Junior Session [Sentry]