Repository navigation
build: Replace pip with uv and PyPI's JSON API - #2640
Merged
Merged
Conversation
Co-Authored-By: Joshua Li <[email protected]>
Co-Authored-By: Joshua Li <[email protected]>
sentry-junior
Bot
force-pushed
the
build/uv-instead-of-pip
branch
from
October 20, 2026 21:32
cdf5212 to
133a11e
Compare
joshuarli
self-requested a review
October 20, 2026 21:36
joshuarli
approved these changes
Oct 20, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 133a11e. Configure here.
| "-", | ||
| ), | ||
| input="\n".join(args.deps).encode(), | ||
| ) |
There was a problem hiding this comment.
Resolver drops upgrade_all stdin contract
Medium Severity
add_pkg now feeds uv pip compile via input= and -, so the process no longer inherits stdin. upgrade_all still invokes it as -r/dev/stdin and pipes package names in, so the documented upgrade path resolves the literal -r/dev/stdin instead of the package list and adds nothing or crashes.
Reviewed by Cursor Bugbot for commit 133a11e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Drops pip from the build pipeline. Builds on #2639, which already reads each release from PyPI's JSON API.
uv has no
pip download, sobuild.pynow downloads files straight from the URLs the JSON API lists:--platform=anyretry.uv build --wheelagainst our index.Other pip users:
validate.pyusesuv venv+uv pip install.add_pkg.pyresolves withuv pip compile.docker/install-pythonsno longer runs ensurepip or installs pip/setuptools/wheel into the interpreters.pipandvirtualenvare removed from the project dependencies.Also bumps
.python-versionfrom 3.11.4 to 3.11.17.ubuntu-latestis rolling over to 26.04, wheresetup-pythonhas no 3.11.4 build, sopre-commitwas failing before any hooks ran.Things to watch:
pkg_resourceswithout declaringsetuptoolswill now fail validation. That matches how our uv-managed environments behave.docker/change only reaches the linux image after merge (the image is built frommain). The macOS job runsinstall-pythonsdirectly, so this PR covers that path.uv buildgets real coverage from new packages as they land.via @joshuarli.
--
View Junior Session [Sentry]