Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 91.40% 91.41% +0.01%
==========================================
Files 118 118
Lines 24551 24551
==========================================
+ Hits 22441 22444 +3
+ Misses 2110 2107 -3
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
changed the title
Member
Author
|
On second thought I'm not sure we should do this, we would be multiplying the retries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic resumable uploads now treat exhausted urllib3 connection retries as transient failures, allowing the upload loop to query the persisted offset and resume instead of canceling the upload. Recognizing
ConnectTimeoutErroralso covers its connection-refused and DNS-resolution subclasses through the existingMaxRetryErrorunwrapping.Regression tests exhaust all three urllib3 connection retries for each failure type and verify that the upload probes its offset and completes successfully.