Skip to content

ref: Introduce a validated usecase name type - #695

Merged
jan-auer merged 2 commits into
mainfrom
ref/usecase-name-type
Oct 20, 2026
Merged

jan-auer merged 2 commits into
mainfrom
ref/usecase-name-type

Conversation

@jan-auer

@jan-auer jan-auer commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Usecase names are validated at client construction and request extraction, but server code still passes them as strings.

Usecase now carries validated identifiers through object contexts, authorization, configuration, and policy checks. Construction and deserialization enforce the existing naming rules. The Rust client uses the type internally and keeps its public API unchanged.

Follow-up to #694.

@jan-auer
jan-auer requested a review from a team as a code owner October 20, 2026 12:57
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.30508% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.41%. Comparing base (fbfb968) to head (190ae37).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
objectstore-types/src/usecase.rs 95.45% 3 Missing ⚠️
bigtable-bench/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   91.39%   91.41%   +0.01%     
==========================================
  Files         118      118              
  Lines       24315    24532     +217     
==========================================
+ Hits        22223    22425     +202     
- Misses       2092     2107      +15     
Components Coverage Δ
Rust Backend 94.86% <98.64%> (+0.01%) ⬆️
Rust Client 81.83% <100.00%> (-0.03%) ⬇️
Python Client 93.28% <ø> (-0.59%) ⬇️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lcian lcian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jan-auer
jan-auer merged commit a02f573 into main Oct 20, 2026
25 checks passed
@jan-auer
jan-auer deleted the ref/usecase-name-type branch October 20, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants