Repository navigation
Conversation
We need a way for querying the expired objects. This is it!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 91.33% 91.48% +0.14%
==========================================
Files 117 118 +1
Lines 24171 24614 +443
==========================================
+ Hits 22077 22517 +440
- Misses 2094 2097 +3
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2e5604a. Configure here.
| let mut ids = Vec::new(); | ||
| for row in rows { | ||
| let id = row.clone(); | ||
| ids.push(ObjectId::from_storage_path(&id).unwrap()); |
There was a problem hiding this comment.
Expired listing panics on bad ids
Medium Severity
list_expired calls ObjectId::from_storage_path and unwraps. One stored path that does not round-trip — an empty key, empty usecase, or a row written outside this code — panics the whole listing instead of returning the Result the method already uses.
Reviewed by Cursor Bugbot for commit 2e5604a. Configure here.


We need a way for querying the expired objects. This is it!