Repository navigation
fix(slack): Keep each Turn to a single Actor - #2574
Merged
Merged
Conversation
A running Turn uses its author's credentials. JUNIOR_CROSS_ACTOR_MID_RUN_MODE=steer and the !! prefix both let a different Slack author inject input into that Turn, which could make Junior act for them with someone else's grants. Remove the mode and the !! cross-author bypass. Another person's mid-run message now always waits for its own Turn. !! still interrupts for the active author. Co-Authored-By: David Cramer <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…mode Another person's !! message joins the running Turn as their own attributed input, as in the default follow_up mode. Plain mentions from other people still wait for their own Turn. Only the configurable steer mode is removed. Co-Authored-By: David Cramer <[email protected]>
sentry-junior
Bot
changed the title
dcramer
approved these changes
Nov 2, 2026
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
|
7 screenshot changes — 7 changed · 0 added · 0 removed Review screenshots in Frameshift
Show 1 more changed screenshot
|
A running Turn uses its author's credentials. Another person's !! message joined that Turn, so their ask ran with the starter's grants. Only the active author's messages now steer a Slack Turn. Another person's message, with or without !!, waits for its own Turn. Co-Authored-By: David Cramer <[email protected]>
sentry-junior
Bot
changed the title
…r-steering # Conflicts: # packages/junior-evals/evals/integration/conversation/steering.eval.ts Co-Authored-By: David Cramer <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each Turn now has one Actor. A running Turn uses its author's credentials, so another person's input must never join it.
Two Slack paths let another person's message join a running Turn:
JUNIOR_CROSS_ACTOR_MID_RUN_MODE=steer(orslack.crossActorMidRunModeincreateApp)!!, in the defaultfollow_upmodeBoth are removed. The Slack steering drain accepts only the active author's messages. Another person's message, with or without
!!, waits for its own Turn.!!still interrupts for the active author. Web and agent-invocation steering already require the same Actor.This is a hard cutover. The env var and app option are removed, not deprecated. junior-prod sets neither one in
server.tsor its config. The!!change is the only behavior change there.Tests
!!mention from a second author during a Turn. Only the active author's message is steered, and the second author gets their own Turn.steering.eval.ts: Alex's!!mention now gets its own follow-up Turn. Removed the configuredsteercase.actors.eval.ts: removed two memory cases that used!!to make a multi-actor Turn. That setup can no longer happen.via @dcramer.
--
View Session [Sentry]