Repository navigation
feat(review-desk): Page the Review item list with a cursor - #2480
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
2 screenshot changes — 2 changed · 0 added · 0 removed Review screenshots in Frameshift
|
dcramer
approved these changes
Oct 31, 2026
sentry-junior
Bot
force-pushed
the
ref/review-desk-paging
branch
from
November 1, 2026 20:01
cc083a1 to
d7e2682
Compare
Member
|
Needs rebased |
sentry-junior
Bot
force-pushed
the
ref/review-desk-paging
branch
from
November 1, 2026 21:14
d7e2682 to
d6a3e1d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d6a3e1d. Configure here.
sentry-junior
Bot
force-pushed
the
ref/review-desk-paging
branch
from
November 1, 2026 21:22
b5e94ad to
38bb4e9
Compare
dcramer
enabled auto-merge (squash)
November 1, 2026 21:23
A failed next page set the query error, and the page then showed only the list error. Show that error only when no page loaded, and show a short error under Load more for a failed next page. Co-Authored-By: David Cramer <[email protected]>
sentry-junior
Bot
force-pushed
the
ref/review-desk-paging
branch
from
November 1, 2026 21:51
38bb4e9 to
1b6ca1b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review desk list returned at most 100 items, so open items past that limit never showed.
GET /api/review-itemsnow pages the open items:cursorandlimit(default 50, max 100). It returnsnextCursorwhen more open items follow.updated_at desc, id desc.searchReviewItemstakes anafterposition in that order.qandconversationId), and a version. A cursor from a different list gets a 400.q) also returns the newest archived matches, up to 50, with the first page only.moreArchivedis set when more match, and the desk then tells the person to add words to the search.Only open items page. With one order across open and archived items, an item that closes while a person reads would move below the cursor and show again on a later page. An open-only cursor does not have this problem: a closed item only leaves the open order. An item that changes while a person reads moves to the top, so a later page does not show it. A refresh shows it again.
The review desk and the Conversation review bar use
useInfiniteQueryand the sharedLoadMorePaginationbutton, like the memory page. The bar shows50+when more items follow, and its side panel has Load more.Mock reporting and the dashboard e2e mock still return
{ items: [...] }, which is valid becausenextCursorandmoreArchivedare optional.Part of the review desk cleanup for #2401.
via David Cramer.
--
View Session [Sentry]