Repository navigation
test(evals): Add behavioral evals for the review desk tools - #2478
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
marked this pull request as ready for review
October 31, 2026 05:04
dcramer
approved these changes
Oct 31, 2026
Cover three agent choices: an Automation run adds an action item for a person's decision and does not wait, a later run updates the open item instead of adding another, and a merged pull request closes its item with a reason. Add an insertReviewItem fixture that writes through the product store. Co-Authored-By: David Cramer <[email protected]>
main added evals/conversation/asking.eval.ts with requestUserInput removed. Its Automation case already checks that a run adds an action item and finishes. The review desk evals keep the dedupe and close cases. Co-Authored-By: David Cramer <[email protected]>
sentry-junior
Bot
force-pushed
the
evals/review-desk
branch
from
November 1, 2026 19:46
4e4bb82 to
ada4f54
Compare
dcramer
approved these changes
Nov 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review desk tools had no evals for how the agent keeps an item up to date or closes it.
evals/review-desk/items.eval.tsadds two behavioral cases. Each one asserts tool calls and their outputs. There is no rubric judge, because each result is a fixed tool effect.addReviewItemstarts a new item. Each add updates the existing item.updateReviewItem, withdoneordismissedand areason.evals/conversation/asking.eval.tsonmainalready checks that an Automation run asks with an action item and finishes, so this file has no case for that.insertReviewIteminsrc/fixture/insert.tsstores a public open item through the product store (chat/review-items/store.ts), like the other insert functions.insertCreationThreadnow returns its Conversation id, so the item can link to it.Status of the cases in CI
updateReviewItemsends its close message through the Vercel queue instead of the eval queue, and the call fails with an OIDC token error. Merge ref(review-desk): Deliver every Review item change through one path #2481 first.via David Cramer.
--
View Session [Sentry]